Skip to content

Network: return JSON problems instead of text/plain errors#273

Merged
reinkrul merged 3 commits into
masterfrom
network-api-problems
May 6, 2021
Merged

Network: return JSON problems instead of text/plain errors#273
reinkrul merged 3 commits into
masterfrom
network-api-problems

Conversation

@reinkrul

@reinkrul reinkrul commented May 3, 2021

Copy link
Copy Markdown
Member

No description provided.

@reinkrul
reinkrul requested review from gerardsn and stevenvegt May 3, 2021 13:51
@codecov

codecov Bot commented May 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #273 (9fe563f) into master (5761696) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
network/api/v1/api.go 97.56% <100.00%> (+27.56%) ⬆️
network/p2p/connection.go 70.96% <0.00%> (-6.46%) ⬇️
network/p2p/impl.go 75.98% <0.00%> (+0.98%) ⬆️

@reinkrul
reinkrul force-pushed the network-api-problems branch from 6afa82a to c46d748 Compare May 4, 2021 07:48
@gerardsn

gerardsn commented May 4, 2021

Copy link
Copy Markdown
Member

part of #112

@gerardsn gerardsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comment, but otherwise looks good to me. I will leave approval to @stevenvegt

Comment thread docs/_static/network/v1.yaml
Comment thread docs/_static/network/v1.yaml
Comment thread network/api/v1/api.go
@reinkrul
reinkrul requested a review from gerardsn May 6, 2021 06:05
@reinkrul
reinkrul merged commit 2e756ad into master May 6, 2021
@reinkrul
reinkrul deleted the network-api-problems branch May 6, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants